Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed MySQL active connections viz title to MySQL total connections #5401

Merged
merged 3 commits into from
Oct 27, 2017
Merged

Changed MySQL active connections viz title to MySQL total connections #5401

merged 3 commits into from
Oct 27, 2017

Conversation

danleerunk
Copy link
Contributor

Should resolve #4812

@elasticmachine
Copy link
Collaborator

Can one of the admins verify this patch?

@ruflin
Copy link
Contributor

ruflin commented Oct 18, 2017

jenkins, test it

@danleerunk
Copy link
Contributor Author

It looks like the build failed while trying to assemble Kafka for testing - I don't think my changes would've impacted that, it sounds like the maybe the actual testing automation failed?

https://beats-ci.elastic.co/job/elastic+beats+pull-request+multijob-linux/1784/beat=metricbeat,label=ubuntu/testReport/junit/test_kafka/Test/test_partition/

kafka.conn: DEBUG: <BrokerConnection node_id=bootstrap host=kafka/172.18.0.4 port=9092>: setting socket option (6, 1, 1)
kafka.conn: INFO: <BrokerConnection node_id=bootstrap host=kafka/172.18.0.4 port=9092>: connecting to 172.18.0.4:9092
kafka.conn: ERROR: Connect attempt to <BrokerConnection node_id=bootstrap host=kafka/172.18.0.4 port=9092> returned error 111. Disconnecting.
kafka.conn: INFO: <BrokerConnection node_id=bootstrap host=kafka/172.18.0.4 port=9092>: Closing connection. ConnectionError: 111
kafka.conn: DEBUG: <BrokerConnection node_id=bootstrap host=kafka/172.18.0.4 port=9092>: reconnect backoff 0.0485859219137 after 1 failures
kafka.client: ERROR: Unable to bootstrap from [('kafka', 9092, 0)]```

@exekias
Copy link
Contributor

exekias commented Oct 23, 2017

You can ignore that errors, seems a temporal issue from our CI, could you please add a CHANGELOG.asciidoc entry?

@danleerunk
Copy link
Contributor Author

hey @exekias - I think I updated the changelog properly, but if you could verify I put my entry in the right place I would be grateful!

exekias
exekias approved these changes Oct 27, 2017
View reviewed changes
Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did, thank you for your contribution! 🎉

jenkins, test it

@exekias exekias merged commit ae0973b into elastic:master Oct 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exekias exekias exekias approved these changes

Assignees
No one assigned
Labels
Metricbeat Metricbeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mysql connections count off by millions
4 participants
@danleerunk @elasticmachine @ruflin @exekias